[Feat] Spacing 컴포넌트 추가

[kongnayeon]

관련 이슈

#39

변경 사항

Spacing 컴포넌트 구현했습니다.
direction, size prop을 전달하면 간격을 줄 수 있어요!

Icon 컴포넌트도 그렇고 동적으로 스타일을 줘야 할 때는 assignInlineVars 함수를 써야 하는데, 이때 JSON 객체를 문자열로 풀었다가 다시 객체로 만들어 주지 않으면 계속 에러가 떠서 조금 더럽지만 코드를 아래와 같이 작성해 두었어요 ㅎㅎ...

 <div
      className={spacingStyle}
      style={JSON.parse(
        JSON.stringify(
          assignInlineVars({
            [directionVar]: direction,
            [sizeVar]: sizeValue,
          })
        )
      )}
      {...rest}
    />

레퍼런스

Summary by CodeRabbit

• 새로운 기능

  • 동적 간격 컴포넌트 추가
  • 프로젝트에 새로운 UI 유틸리티 라이브러리 통합

• 의존성 업데이트

  • @vanilla-extract/dynamic 패키지 추가
  • @repo/ui 개발 의존성 포함

• 리팩토링

  • 기존 테스트 컴포넌트를 새로운 간격 컴포넌트로 대체

이 업데이트는 애플리케이션의 UI 구성 요소 및 스타일링 기능을 개선합니다.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/ui/src/components/Spacing/Spacing.css.ts

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@repo/eslint-config' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

개요

Walkthrough

이 풀 리퀘스트는 UI 컴포넌트 라이브러리에 새로운 Spacing 컴포넌트를 추가하는 변경 사항을 포함하고 있습니다. @vanilla-extract/dynamic을 사용하여 동적 스타일링을 구현하고, packages/ui 디렉토리에 새로운 컴포넌트를 도입했습니다. 이 변경은 프로젝트의 UI 구성 요소 라이브러리를 확장하고 유연한 간격 스타일링을 지원합니다.

Changes

파일	변경 요약
apps/web/package.json	@repo/ui를 devDependencies에 추가
package.json	@vanilla-extract/dynamic 의존성 추가 (v2.1.2)
packages/ui/src/components/Spacing/Spacing.css.ts	동적 스타일링을 위한 CSS 변수 및 스타일 생성
packages/ui/src/components/Spacing/Spacing.tsx	새로운 Spacing React 컴포넌트 구현
packages/ui/src/components/index.ts	Spacing 컴포넌트로 내보내기 변경

Possibly related PRs

• [Chore]: ui 패키지 초기 셋팅 #34: UI 패키지의 초기 구성 설정
• [Feat] pnpm workspace 추가 #42: apps/web/package.json에 @repo/ui 의존성 추가

Poem

🐰 간격의 마법사, 토끼의 춤 🌈

공간을 자유롭게 나누는 손길
행과 열, 크기를 춤추게 하네
바닐라 추출의 마법으로
UI의 리듬을 만들어가네! 🎨

Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

packages/ui/src/components/Spacing/Spacing.tsx (1)

16-21: size 값 계산 로직을 단순화할 수 있습니다.

현재 구현된 조건문이 불필요하게 복잡합니다. 'row'와 'column' 모두 동일한 결과를 반환하고 있습니다.

다음과 같이 단순화할 수 있습니다:

-  const sizeValue =
-    direction === 'row'
-      ? tokens.spacing[size]
-      : direction === 'column'
-        ? tokens.spacing[size]
-        : 'auto';
+  const sizeValue = ['row', 'column'].includes(direction)
+    ? tokens.spacing[size]
+    : 'auto';

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8461f8b and d4cb9b8.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

• apps/web/package.json (1 hunks)
• package.json (1 hunks)
• packages/ui/src/components/Spacing/Spacing.css.ts (1 hunks)
• packages/ui/src/components/Spacing/Spacing.tsx (1 hunks)
• packages/ui/src/components/index.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/ui/src/components/index.ts

🔇 Additional comments (2)

packages/ui/src/components/Spacing/Spacing.css.ts (1)

1-11: CSS 변수와 스타일 구현이 깔끔합니다! 👍

Vanilla Extract를 사용한 CSS 변수 정의와 스타일 구현이 명확하고 재사용 가능하게 잘 작성되었습니다.

package.json (1)

39-39: 의존성 추가가 적절합니다! 👍

@vanilla-extract/dynamic 패키지 추가와 버전 선택이 기존 vanilla-extract 패키지들과 잘 어울립니다.

[minseong0324]

고생하셨어요! theme 패키지 고치도록 할게요!