[PC-254] 코루틴 유틸함수 추가 및 LoginScreen 불필요한 Spacer 제거 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgyuuAn
added
기능 ⚒️
sksowk156
reviewed
Jan 12, 2025
sksowk156
added
머지 해도될듯염🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
2. 📌 이 부분은 꼭 봐주세요!
Padding으로 해결할 수 있는 부분은 최대한 Padding으로 해결하면 좋아요!
Spacer()로 하게 될 경우 렌더링 되는 과정에서 트리에 UI Node가 추가되어서 성능상 더 좋지 않을 수 있어요.Modifier.padding()으로 표현할 경우 해당 노드에 붙어서 옵션만 달아주는 느낌이라서 훨씬 좋아요!Spacer(modifier=Modifer.weight(1f)같은 경우에만 Spacer를 사용하면 좋을 것 같습니다~~SideEffect도 Intent로만 호출할 수 있도록 바꾸고,
해당 함수의 예시를 repeatOnStarted()로 하면 될 것 같습니다~