[PC-538] 프로필 등록 이미지 기능 추가 및 API 연결 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgyuuAn
added
기능 ⚒️
sksowk156
reviewed
Feb 6, 2025
sksowk156
added
머지 해도될듯염🌟
|
이미지 리사이징 로직 때문에 ProfileRepository에 안드로이드 의존성이 생겨서 테스트가 깨졌었는데, (리사이징할때 Context가 필요해서요!) 이 부분 ImageResizer로 객체 분리하고 ImageResizer를 Mock으로 떼운 다음 테스트 통과하게 만들었습니다~~~ Spy객체를 사용하고 있는데 직접 구현한 Mock이라고 생각하시면 되어요...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
2025-02-06.11.02.26.mov