Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-551] 매칭 홈 분기 화면 UI 구현 및 API 연결 #62

Merged
merged 17 commits into from
Feb 11, 2025

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Feb 10, 2025

1. ⭐️ 변경된 내용

  • 매칭 홈 분기 화면 UI 구현
  • 매칭 수락, 매칭 조각 확인하기 API
  • 매칭 홈 더미데이터 걷어내고 실제 데이터로 변경

2. 🖼️ 스크린샷(선택)

image image

@tgyuuAn tgyuuAn added UI/UX 🎨 디자인 시스템, 디자인 리소스 관련 코드 🎨 기능 ⚒️ 새로운 기능 구현 ⚒️ 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn labels Feb 10, 2025
@tgyuuAn tgyuuAn requested a review from sksowk156 February 10, 2025 19:31
@tgyuuAn tgyuuAn self-assigned this Feb 10, 2025
Copy link
Contributor

@sksowk156 sksowk156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 태규님!!!

Comment on lines +3 to +13
data class MatchInfo(
val matchId: Int,
val matchStatus: MatchStatus,
val description: String,
val nickname: String,
val birthYear: String,
val location: String,
val job: String,
val matchedValueCount: Int,
val matchedValueList: List<String>,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import com.puzzle.designsystem.foundation.PieceTheme

@Composable
internal fun MatchingPendingScreen(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잠깐 이쪽 화면에 한 화면에서 state를 어떻게 만들어야 하나 고민했었는데, 생각해보니까 이렇게 하면 훨씬 덜 복잡해지고 깔끔하겠네요👍 👍 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오예~~~ 가독성 괜찮나요 ㅎㅎㅎㅎ

감사합니둥

@sksowk156 sksowk156 added 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟 기능 ⚒️ 새로운 기능 구현 ⚒️ and removed 기능 ⚒️ 새로운 기능 구현 ⚒️ 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 labels Feb 11, 2025
@tgyuuAn tgyuuAn merged commit 75c8fa6 into develop Feb 11, 2025
1 check passed
@tgyuuAn tgyuuAn deleted the feature/tgyuu/PC-551 branch February 11, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX 🎨 디자인 시스템, 디자인 리소스 관련 코드 🎨 ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn 기능 ⚒️ 새로운 기능 구현 ⚒️ 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants