[PC-566] 프로필 미리보기 화면 ui 구현 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksowk156
added
UI/UX 🎨
|
아 그리고 사진 보기에서 매칭 수락하기 버튼은 미리보기에선 안보이게 처리해뒀어요! |
tgyuuAn
approved these changes
Feb 12, 2025
Comment on lines
243
to
251
| if (isApproveButtonEnabled) { | ||
| PieceRoundingSolidButton( | ||
| label = buttonLabel, | ||
| onClick = onApproveClick, | ||
| modifier = Modifier | ||
| .align(Alignment.BottomCenter) | ||
| .padding(bottom = 10.dp), | ||
| ) | ||
| } |
There was a problem hiding this comment.
p2)
enabled라는 속성은 버튼 내에서 실제로 있는 속성이니까
가시성 여부는 isShow 같은 걸로 바꾸면 좋을 것 같습니다~
Comment on lines
93
to
95
| activityRegion: String, | ||
| occupation: String, | ||
| smokeStatue: String, |
There was a problem hiding this comment.
p3)
이거 제가 지금 작업하고 있는 것에서도 다 바꾸고 있는데,
새로 작성된 코드중에서
ActivityRegion -> location,
occupation -> job,
smokeStatue -> somokeStatus
로 바꿔주세요! API에서 그렇게 내려주고 있어서 context를 비슷하게 가져가려고요~
tgyuuAn
added
머지 해도될듯염🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
프로필 미리보기 화면 ui 구현
2. 🖼️ 스크린샷(선택)
KakaoTalk_20250212_024438697.mp4
3. 💡 알게된 부분
4. 📌 이 부분은 꼭 봐주세요!
그 State에 MyProfile클래스가 없어서 일단 OpponentProfile 클래스를 사용했는데, 개발하시다가 MyProfile 클래스가 생기면 그때 변경해두겠습니다!