Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-588] 에러 로깅 추가 #66

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[PC-588] 에러 로깅 추가 #66

merged 4 commits into from
Feb 13, 2025

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Feb 12, 2025

1. ⭐️ 변경된 내용

  • Firebase Crashlytics 추가
  • ErrorHelper로 Send된 Error 로깅

2. 🖼️ 스크린샷(선택)

image

@tgyuuAn tgyuuAn added 기능 ⚒️ 새로운 기능 구현 ⚒️ 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn labels Feb 12, 2025
@tgyuuAn tgyuuAn requested a review from sksowk156 February 12, 2025 17:25
@tgyuuAn tgyuuAn self-assigned this Feb 12, 2025
@tgyuuAn tgyuuAn force-pushed the feature/tgyuu/PC-588 branch 2 times, most recently from ce8da97 to 7be75a0 Compare February 12, 2025 17:31
@tgyuuAn tgyuuAn force-pushed the feature/tgyuu/PC-588 branch from 7be75a0 to 81d04a9 Compare February 12, 2025 17:32
Copy link
Contributor

@sksowk156 sksowk156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👍

Comment on lines +6 to +12
class ErrorDataSourceImpl @Inject constructor(
private val firebaseCrashlytics: FirebaseCrashlytics,
) : ErrorDataSource {
override suspend fun logError(exception: Throwable) {
firebaseCrashlytics.recordException(exception)
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Comment on lines +77 to +79
fun provideErrorDataSource(
@Debug debugErrorDataSource: ErrorDataSource,
@Release releaseErrorDataSource: ErrorDataSource,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@sksowk156 sksowk156 added 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟 and removed 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 labels Feb 13, 2025
@tgyuuAn
Copy link
Member Author

tgyuuAn commented Feb 13, 2025

고생하셨습니다!! 👍

야밍~~~~

@tgyuuAn tgyuuAn merged commit 5141ee5 into develop Feb 13, 2025
1 check passed
@tgyuuAn tgyuuAn deleted the feature/tgyuu/PC-588 branch February 13, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn 기능 ⚒️ 새로운 기능 구현 ⚒️ 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants