[PC-596] 설정 페이지 웹뷰 및 API 연결 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgyuuAn
commented
Feb 13, 2025
Comment on lines
+31
to
+32
| @Serializable | ||
| data class WebViewRoute(val title: String, val url: String) : SettingGraphDest() |
There was a problem hiding this comment.
이 화면에서는 네비게이션 바가 없어져야 해서 추가했습니다!
tgyuuAn
commented
Feb 13, 2025
Comment on lines
+15
to
+26
| @Composable | ||
| internal fun WebViewRoute( | ||
| title: String, | ||
| url: String, | ||
| viewModel: WebViewViewModel = hiltViewModel(), | ||
| ) { | ||
| WebViewScreen( | ||
| title = title, | ||
| url = url, | ||
| onBackClick = { viewModel.navigationHelper.navigate(NavigationEvent.NavigateUp) }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
웹뷰 화면에서는 State도 없고 MVI를 넣을필요가 전혀 없을 것 같아서 그냥 MavericksViewModel이 아니라 ViewModel Inject 시켰어용~~
sksowk156
added
머지 해도될듯염🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
2025-02-13.6.12.55.mov
3. 💡 알게된 부분
위 사진 처럼 웹뷰 페이지가 뜨지 않을 때,
웹뷰 속성 아래에 아래 속성을 넣으면 해결 됨!!