-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TNT-142] 트레이니 초대 코드 화면 작성, DIContainer 추가 #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syss220211
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 새벽의 DIContainer 소동기 수고하셨습니다!
제가 저희 피그마 구조도에 반영해놓을게요
넵 좋습니다! 👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What is the PR?
🪄 Changes
🌐 Common Changes
🔥 PR Point
Swift-Dependencies는 모듈 영역에 할당되므로, 각 모듈에서 등록한 DependencyValue는 해당 모듈을 import해야 사용가능합니다.
이러한 이유로 Data->Domain 구조에서 Domain/UseCase 작성 시 @dependency로 Data에서 등록한 Repository를 가져올 수 없습니다.
따라서 DIContainer 모듈을 추가하여 해당 문제를 해결했습니다.
결론적으로 Swift-Dependencies 외 별도 라이브러리 추가 없이, Domain은 Data를 모르는채, Presentation에서 완성된 UseCase를 사용할 수 있습니다.
🙆🏻 To Reviewers
💭 Related Issues