[TNT-158] postSingIn 구현 완료 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…158-trainerSignup
FpRaArNkK
reviewed
Feb 1, 2025
TnT/.gitignore
Outdated
Comment on lines
81
to
82
| # **/*.plist | ||
| # Support/*.plist | ||
| **/*.plist | ||
| Resources/GoogleService-Info.plist |
There was a problem hiding this comment.
저러면 Config/Info.plist도 ignoring이라 **/GoogleService-Info.plist만 남겨주시는게 좋아보여요!
Comment on lines
41
to
43
| public func kakaoLogout() async { | ||
| // 미구현 | ||
| } |
There was a problem hiding this comment.
미구현은 주석이나 삭제처리해주시면 좋을 것 같아요!
| } | ||
|
|
||
| // public func appleLoginResult() async throws -> Result<PostSocialLoginReqDTO, Error> { | ||
| // let result = await loginManager.appleLogin() |
| @@ -13,7 +13,7 @@ import Domain | |||
|
|
|||
| /// 사용자 관련 네트워크 요청을 처리하는 UserRepository 구현체 | |||
| public struct UserRepositoryImpl: UserRepository { | |||
|
|
|||
| private let loginManager = SNSLoginManager() | |||
| @@ -7,6 +7,7 @@ | |||
| // | |||
|
|
|||
| import Dependencies | |||
| import SwiftUI | |||
Comment on lines
68
to
76
| // MARK: - Repository | ||
| public func postSocialLogin(_ reqDTO: PostSocialLoginReqDTO) async throws -> PostSocialLoginResDTO { | ||
| return try await userRepostiory.postSocialLogin(reqDTO) | ||
| } | ||
|
|
||
| public func postSignUp(_ reqDTO: PostSignUpReqDTO, profileImage: Data?) async throws -> PostSignUpResDTO { | ||
| return try await userRepostiory.postSignUp(reqDTO, profileImage: profileImage) | ||
| } | ||
|
|
There was a problem hiding this comment.
extension DefaultUseUseCase: UseRepository 로
분리해서 작성해보는건 어떨까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What is the PR?
🪄 Changes
🙆🏻 To Reviewers
💭 Related Issues