[TNT-210] 트레이너 마이페이지, 홈 캘린더 화면 작성 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FpRaArNkK
approved these changes
Feb 4, 2025
Comment on lines
72
to
+79
| case .getVerifyInvitationCode: | ||
| return ["Content-Type": "application/json"] | ||
| case .getFirstInvitationCode: | ||
| return nil | ||
| case .getDateLessionList: | ||
| return ["Content-Type": "application/json"] | ||
| case .getReissuanceInvitationCode: | ||
| return ["Content-Type": "application/json"] |
There was a problem hiding this comment.
참고용으로 올려드립니다! 아래와 같이 작성하면 조금? 더 편합니다 갠취인것 같아요.
case .getVerifyInvitationCode, .getDateLessionList, .getReissuanceInvitationCode:
return ["Content-Type": "application/json"]
Comment on lines
+73
to
+75
| public struct SessonEntity: Equatable, Encodable { | ||
| public let id = UUID().uuidString | ||
| public let ptLessonId: String |
There was a problem hiding this comment.
Foreach에서 id값을 활용하기 위해서입니다!
@ViewBuilder
private func RecordList() -> some View {
VStack {
if let record = store.tappedsessionInfo {
ForEach(record.lessons, id: \.id) { record in
SessionCellView(session: record) {
send(.tapSessionCompleted(id: record.ptLessonId))
}
}
} else {
RecordEmptyView()
}
}
.padding(.horizontal, 20)
}There was a problem hiding this comment.
아하 그런거라면 API에서 ResponseDTO -> SessionEntity로 Mapping할 때
DTO에서 받아오는 id를 entity로 가져올 수 있게
init에 추가해주시면 좋을 것 같아요! 기본값은 UUID 넣어주는 방향으로요.
There was a problem hiding this comment.
😮 그렇네요. 수정해서 반영하고 머지하겠습니다!
|
|
||
| } | ||
|
|
||
| /// 수업 리스트 상단 타이틀 |
There was a problem hiding this comment.
섹션마다 설명 주석이 있으니 훨씬 좋은데요? 👍👍
Comment on lines
+139
to
+149
| state.view_isPopUpPresented = false | ||
| state.view_popUp = .logoutCompleted | ||
| state.view_isPopUpPresented = true | ||
|
|
||
| case .logoutCompleted: | ||
| state.view_isPopUpPresented = false | ||
|
|
||
| case .withdraw: | ||
| state.view_isPopUpPresented = false | ||
| state.view_popUp = .withdrawCompleted | ||
| state.view_isPopUpPresented = true |
There was a problem hiding this comment.
아 컨텐츠 트랜지션을 막으려면 걍 꺼버리고 다시 키면 됐었네요..!
아 좋습니다 🔥🔥
FpRaArNkK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What is the PR?
🪄 Changes
📸 Screenshot
🙆🏻 To Reviewers
💭 Related Issues