Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TNT-210] 수업 완료 시 토스트 메시지 추가 #84

Closed
wants to merge 1 commit into from

Conversation

syss220211
Copy link
Member

📌 What is the PR?

  • 수업 완료 시 토스트 메시지 추가

🪄 Changes

  • 성공한 경우 토스트 메시지를 추가하였습니다.

🌐 Common Changes

  • 디자인 시스템의 TToastModifier에서 제네릭이 사용되는 부분이 없어서 사용 시 오류가 발생하여 제거하였습니다.

🙆🏻 To Reviewers

  • 토스트 메시지 쪽 확인부탁드려요!
  • 추가로 저희 운동 기록하기는 아직 작업이 안 나오는것 같은데 제외하도 되는것인지... ??

💭 Related Issues

@syss220211 syss220211 added the ✨Feat 새로운 기능 구현 (새로운 로직 추가, UI 구현 등) label Feb 13, 2025
@syss220211 syss220211 requested a review from FpRaArNkK February 13, 2025 12:32
@syss220211 syss220211 self-assigned this Feb 13, 2025
Copy link
Contributor

@FpRaArNkK FpRaArNkK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 멘션 남겨놓은 부분 확인 부탁드려요!


/// 수업 완료 후 토스트 메시지
case .sessionToastMessage:
state.sessionTMessage = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 해당 부분은 NotificationCenter.default.post(toast:) 로 보내시기만 하면 앱 전역에 깔린 오버레이에 토스트가 표시됩니다!
화면에 안붙이셔도 표시할 수 있어요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 넵넵~!

@@ -117,7 +122,7 @@ public struct TrainerHomeView: View {
if let record = store.tappedsessionInfo, !record.lessons.isEmpty {
ForEach(record.lessons, id: \.id) { record in
SessionCellView(session: record) {
send(.tapSessionCompleted(id: record.ptLessonId))
send(.tapSessionCompleted(id: Int(record.ptLessonId)!))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 강제 언래핑보다는 ?? 0 과 같이 처리해주시면 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syss220211 syss220211 closed this Feb 13, 2025
@syss220211 syss220211 deleted the TNT-210-TrainerHome branch February 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feat 새로운 기능 구현 (새로운 로직 추가, UI 구현 등)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TNT-210] 트레이너 홈 화면 작성
2 participants