Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TNT-213] 트레이너 회원 목록에서 회원 초대 연결 & 트레이너 캘린더 API연결 #87

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

syss220211
Copy link
Member

@syss220211 syss220211 commented Feb 13, 2025

📌 What is the PR?

  • 트레이너 회원 목록에서 회원 초대 연결
  • 트레이너 캘린더에 수업 완료 API 연결
  • 트레이너 캘린더 데이터 3개월으로 조정

💭 Related Issues

@syss220211 syss220211 added the ✨Feat 새로운 기능 구현 (새로운 로직 추가, UI 구현 등) label Feb 13, 2025
@syss220211 syss220211 self-assigned this Feb 13, 2025
@syss220211 syss220211 changed the title [TNT-213] 트레이너 회원 목록에서 회원 초대 연결 [TNT-213] 트레이너 회원 목록에서 회원 초대 연결 & 트레이너 캘린더 API연결 Feb 13, 2025
@FpRaArNkK FpRaArNkK self-requested a review February 13, 2025 20:30
Copy link
Contributor

@FpRaArNkK FpRaArNkK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새벽까지 고생하셨습니다..! 🔥🔥🔥

Comment on lines +138 to +139
startTime: self.startTime.toDate(format: .ISO8601)?.toString(format: .a_HHmm) ?? "",
endTime: self.endTime.toDate(format: .ISO8601)?.toString(format: .a_HHmm) ?? "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 와서 보니까 해당 내용은 Entity에서 Date로 관리하고,
화면에 표시할때 toString 해주면 더 좋았을 것 같네요!
나중에 한 번 반영해보죠..!

Comment on lines 78 to 82
.onChange(of: store.state.selectedDate, { oldValue, newValue in
let startOfDay = Calendar.current.startOfDay(for: newValue)
let startOfDay: Date = Calendar.current.startOfDay(for: newValue)
store.selectedDate = startOfDay
store.send(.view(.calendarDateTap))
send(.calendarDateTap)
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 나중에 꼭 같이 봅시다..!

@syss220211 syss220211 merged commit 2a91d51 into develop Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feat 새로운 기능 구현 (새로운 로직 추가, UI 구현 등)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TNT-213] 트레이너 회원 목록 작성
2 participants