[CMB-18181] | Fix Package.swift included in sources
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MouadBenjrinija
changed the title
Package.swift included in sourcesPackage.swift included in sources
MouadBenjrinija
changed the title
Package.swift included in sourcesPackage.swift included in sources
HagerElsayed
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main target of the package uses
.(root folder) as sources folder, this makesPackage.swiftpart of the source files, which wasn't causing issues when used through SPM (perhaps it excludes it automatically under the hood), but when imported throughTuistit caused a compile time error asPackage.swiftshould be excluded from sources.https://yassir.atlassian.net/browse/CMB-18181