Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resetTotalItems on children changes #102

Merged
merged 1 commit into from
Nov 18, 2019
Merged

resetTotalItems on children changes #102

merged 1 commit into from
Nov 18, 2019

Conversation

abhinavdalal-iconnect
Copy link
Contributor

No description provided.

@abhinavdalal-iconnect
Copy link
Contributor Author

this PR is the second part of #71

@abhinavdalal-iconnect
Copy link
Contributor Author

@YIZHUANG let me know if any changes needed..
one additional scenario i covered is onResize to smaller screen and then we have enough children; we now call setClones with the resetCurrentSlide flag set to true..

@abhinavdalal-iconnect
Copy link
Contributor Author

@YIZHUANG could you please test, merge and release these changes

@YIZHUANG
Copy link
Owner

YIZHUANG commented Nov 7, 2019

Hi sorry for the wait as i havent been in a good place recenctly will review it asap after i left.

@YIZHUANG YIZHUANG merged commit a4159e5 into YIZHUANG:master Nov 18, 2019
@YIZHUANG YIZHUANG mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YIZHUANG YIZHUANG YIZHUANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavdalal-iconnect @YIZHUANG