-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to eslint #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@YIZHUANG please review this pr.. This pr will make the development more easier once this is merge I will send another pr for vscode and editor config. We can configure preetier according to our needs initially the project used double quotes but I changed to single. |
I suppressed all the warnings which we can fix in future updates most of they are due to the usage of any keyword in typings. We are left with 2 errors which I tried to fix but have no idea how to fix it. |
Thank you for the PR. |
I went through the package.json and found that husky is not configured I will create a separate PR with husky pre-commit hook and all the necessary commands. I think we should not make this PR more complicated..! |
Reason for PR
palantir/tslint#4534
What did I do?
While setting up I found few typescript warning which we need to fix.