This repository has been archived by the owner on Aug 19, 2019. It is now read-only.
Rewrite to use react instead of @yr/component #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Saegrov
commented
May 22, 2018
Saegrov
commented
- Change to typescript
- Add prettier
- Remove karma-tests
* Change to typescript * Add prettier * Remove karma-tests
esseb
reviewed
May 22, 2018
| */ | ||
| shouldComponentUpdate(nextProps, nextState, nextContext) { | ||
| shouldComponentUpdate(_nextProps: any, nextState: any): boolean { |
There was a problem hiding this comment.
Is the underscore for unused parameter a typescript convention?
There was a problem hiding this comment.
esseb
reviewed
May 22, 2018
src/lib/select.ts
Outdated
|
|
||
| const isEqual = require('@yr/is-equal'); | ||
| const runtime = require('@yr/runtime'); | ||
| export type SomeFn = (selectors: any[], context?: any, props?: any) => any; |
There was a problem hiding this comment.
I don't understand this name. Can you think of a better name than SomeFn?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.