Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call pytest fixture functions from code anymore #396

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Don't call pytest fixture functions from code anymore #396

merged 1 commit into from
Nov 16, 2018

Conversation

sjaensch
Copy link
Contributor

This is an error in pytest 4: pytest-dev/pytest#3950

Since the fixture is so short I opted to just copy it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling b0f6e73 on sjaensch:fix_pytest4_compatibility into 09aa528 on Yelp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling b0f6e73 on sjaensch:fix_pytest4_compatibility into 09aa528 on Yelp:master.

@sjaensch sjaensch mentioned this pull request Nov 15, 2018
Merged
@sjaensch sjaensch merged commit 75c93c6 into Yelp:master Nov 16, 2018
@sjaensch sjaensch deleted the fix_pytest4_compatibility branch November 16, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macisamuele macisamuele macisamuele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjaensch @coveralls @macisamuele