COMPINFRA-1605, add labels to k8s workloads #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysharma096
requested review from
nemacysts,
Rob-Johnson,
ilkinmammadzada and
gmdfalk
gmdfalk
approved these changes
Oct 11, 2022
nemacysts
approved these changes
Oct 11, 2022
cuza
added a commit
that referenced
this pull request
Oct 27, 2022
…on_to_run_api_in_dev_mode * origin/master: (157 commits) Updating docs with playground make targets Fixing typo in Makefile Fixing kind local cluster Released 0.150.1 via make release Added paasta playground documentation to index.rst file Released 0.150.0 via make release Added documentation to readthedocs for paasta playground Released 0.149.3 via make release MLCOMPUTE-216 | increase dra mass rolout executor range to 16 Released 0.149.2 via make release Released 0.149.1 via make release COMPINFRA-1050, COMPINFRA-1043: fix paasta status output to show full version if provided (#3473) renaming user kube config path var Add option to pass kubeconfig path, context to KubeClient constructor as params replacing subprocess with kubernetes python lib Adding allow_no_verify_deploy flag to support no_verify_deploy Released 0.149.0 via make release COMPINFRA-1605, add labels to k8s workloads (#3479) fixing check fail, adding type annotations, more exceptions fixing unit tests, exceptions and sanitisation ...
cuza
added a commit
that referenced
this pull request
Oct 27, 2022
* origin/master: (54 commits) Updating docs with playground make targets Fixing typo in Makefile Fixing kind local cluster Released 0.150.1 via make release Added paasta playground documentation to index.rst file Released 0.150.0 via make release Added documentation to readthedocs for paasta playground Released 0.149.3 via make release MLCOMPUTE-216 | increase dra mass rolout executor range to 16 Released 0.149.2 via make release Released 0.149.1 via make release COMPINFRA-1050, COMPINFRA-1043: fix paasta status output to show full version if provided (#3473) renaming user kube config path var Add option to pass kubeconfig path, context to KubeClient constructor as params replacing subprocess with kubernetes python lib Adding allow_no_verify_deploy flag to support no_verify_deploy Released 0.149.0 via make release COMPINFRA-1605, add labels to k8s workloads (#3479) fixing check fail, adding type annotations, more exceptions fixing unit tests, exceptions and sanitisation ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding required labels to k8s workloads in Paasta,
yelp.com/owneris mandatory but addingpaasta.yelp.com/poolas a formality.I have already created a puppet PR to prevent a bounce - https://github.yelpcorp.com/sysgit/puppet/pull/7679