Fix get_instance_configs_for_service to use cluster arg #3764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
paasta mesh-status
, I was getting an odd error indicating that we were trying to get information for an EksInstance for an instance and cluster that should not have been running on EKS.Turns out that this is due to us naively getting the first instance_config from the results of get_instance_configs_for_service, which was not honoring the
clusters
argument.This change now starts to honor said clusters argument.
All uses of this function either did not pass the
clusters
arg (and therefore used the full list of supported clusters from system configs), or expected only a single instance and was impacted by this same bug.No clusters arg:
Unaffected by bug:
Probably buggy: