Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_instance_configs_for_service to use cluster arg #3764

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jfongatyelp
Copy link
Contributor

While running paasta mesh-status, I was getting an odd error indicating that we were trying to get information for an EksInstance for an instance and cluster that should not have been running on EKS.

Turns out that this is due to us naively getting the first instance_config from the results of get_instance_configs_for_service, which was not honoring the clusters argument.

This change now starts to honor said clusters argument.

All uses of this function either did not pass the clusters arg (and therefore used the full list of supported clusters from system configs), or expected only a single instance and was impacted by this same bug.

No clusters arg:

Unaffected by bug:

Probably buggy:

@jfongatyelp jfongatyelp requested a review from EvanKrall January 4, 2024 01:43
@jfongatyelp jfongatyelp merged commit f497235 into master Jan 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants