Use DNS names for MySQL host and avoid envoy discovery #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaySagarGonabavi
requested review from
nemacysts,
flopex,
matt-ullmer and
alexanderjulianmartinez
matt-ullmer
approved these changes
Aug 8, 2024
alexanderjulianmartinez
approved these changes
Aug 8, 2024
VinaySagarGonabavi
force-pushed
the
u/gonabavi/DREIMP-10935_avoid_using_envoy_for_mysql_backend_discovery
branch
from
7dd8216 to
99ad622
Compare
flopex
reviewed
Aug 8, 2024
VinaySagarGonabavi
force-pushed
the
u/gonabavi/DREIMP-10935_avoid_using_envoy_for_mysql_backend_discovery
branch
from
99ad622 to
29a04d8
Compare
flopex
approved these changes
Aug 9, 2024
VinaySagarGonabavi
force-pushed
the
u/gonabavi/DREIMP-10935_avoid_using_envoy_for_mysql_backend_discovery
branch
from
29a04d8 to
bef6f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid adding more traffic through envoy. Cloudmap DNS discovery is setup for all MySQL roles in dev and prod