U/ahaswell/perel 4210 per endpoint alerting schema #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejoycekung
reviewed
Sep 3, 2024
| @@ -1072,7 +1072,7 @@ internally at Yelp. | |||
| integer, this cannot be specified as a floating-point number. | |||
|
|
|||
| Error Alerting | |||
| `````````````` | |||
| ^^^^^^^^^^^^^^^^^^^^ | |||
There was a problem hiding this comment.
what's the difference? between the backtick and the ^ ?
There was a problem hiding this comment.
There was a problem hiding this comment.
There are some formatting errors with the rst that makes the readthedocs a bit wrong, i changed it to see if it will help
Co-authored-by: Joyce Kung <[email protected]>
Co-authored-by: Joyce Kung <[email protected]>
thejoycekung
approved these changes
Sep 3, 2024
cuza
approved these changes
Sep 3, 2024
mtbentley
approved these changes
Sep 3, 2024
ahaswell
deleted the
u/ahaswell/perel-4210-per-endpoint-alerting-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update smartstack schema to allow per endpoint alerting
Doc with proposed update and discussion.
perel-4210 per endpoint alerting
Linked: update to gitolite/schemas/smartstack_schema.json
https://github.yelpcorp.com/packages/py-gitolite/pull/117