Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regular filename reference in autotune files #3961

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

nemacysts
Copy link
Member

We've generally decided that we'll be leaving files as eks-.yaml - and while there's some additional steps that need to be taken, those will need to happen once we've gotten rid of all of the kubernetes-.yaml files.

As we still have some unmigrated operators, that means we still need to wait. However, we can go ahead and update the comment in the autotune files since those have recently caused some confusion (and assume that anyone looking at autotune files is looking at them for non-operator services)

example diff:

--- a/yelp_eng_people/autotuned_defaults/kubernetes-pnw-corpdev.yaml
+++ b/yelp_eng_people/autotuned_defaults/kubernetes-pnw-corpdev.yaml
@@ -2,10 +2,10 @@
 # automated processes.
 #
 # Your service will use these values if they are not defined in
-# yelp_eng_people/kubernetes-pnw-corpdev.yaml.
+# yelp_eng_people/eks-pnw-corpdev.yaml.
 #
 # If you would like to override a config value defined here, add the config
-# value to yelp_eng_people/kubernetes-pnw-corpdev.yaml instead of editing this file.
+# value to yelp_eng_people/eks-pnw-corpdev.yaml instead of editing this file.

We've generally decided that we'll be leaving files as eks-*.yaml - and
while there's some additional steps that need to be taken, those will
need to happen once we've gotten rid of all of the kubernetes-*.yaml
files.

As we still have some unmigrated operators, that means we still need to
wait. However, we can go ahead and update the comment in the autotune
files since those have recently caused some confusion (and assume that
anyone looking at autotune files is looking at them for non-operator
services)
@nemacysts nemacysts merged commit 966e1d8 into master Sep 17, 2024
9 checks passed
@nemacysts nemacysts deleted the luisp/reference-eks-in-autotune branch November 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants