Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iam_role in service_shard_update #3994

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

panbenson
Copy link
Contributor

@panbenson panbenson commented Dec 16, 2024

create a --iam-role option to provide permissions when using service_shard_update

@panbenson panbenson requested a review from a team as a code owner December 16, 2024 15:10
@nemacysts
Copy link
Member

@panbenson just curious: how would this be used? would a human manually add something like

my_cool_config_section: &my_cool_anchor
    ...

to the file and then call this script with --anchor my_cool_anchor?

@panbenson
Copy link
Contributor Author

panbenson commented Dec 16, 2024

@panbenson just curious: how would this be used? would a human manually add something like

my_cool_config_section: &my_cool_anchor
    ...

to the file and then call this script with --anchor my_cool_anchor?

@nemacysts yes that's the idea! that way additional/custom config can be added for sections once they've gone thru review

edit: switch this to configure iam role only!

@panbenson panbenson force-pushed the u/bpan/allow-custom-service-shard-configs branch from 3d9821e to 629c7cf Compare December 16, 2024 17:56
@panbenson panbenson changed the title Add support for anchors in service_shard_update Add support for iam_role in service_shard_update Dec 16, 2024
@panbenson panbenson requested a review from nemacysts December 16, 2024 20:19
@panbenson panbenson merged commit dbe4ada into master Dec 16, 2024
10 checks passed
@panbenson panbenson deleted the u/bpan/allow-custom-service-shard-configs branch December 16, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants