Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Mixer: Setting a column volume does not work as expected #1481

Closed
iampremo opened this issue Jul 31, 2023 · 4 comments
Closed

Sound Mixer: Setting a column volume does not work as expected #1481

iampremo opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation are required by this issue ide-bug Bugs with the GameMaker IDE import An issue imported from the old database
Milestone

Comments

@iampremo
Copy link
Member

GM-201

While writing up and testing the sound mixer, I've found what I would consider to be an error. When working with a REAL mixer, if you change the master volume it affects the other volumes in a relative fashion. Ie: if a sound is at 75% volume and you set the master volume to 50% the final sound will have a volume of 37.5%. Currently the master volume for a column simply sets the final volume for each sound resource to be the same.

This GREATLY reduces the functionality of the sound mixer, because ideally you'd be able to tweak the volumes on each sound in one column then compare it to the sounds in another and then use the master column volume to raise/lower all sounds relative value to bring everything in line. As it currently stands, the column volume control is pretty much useless.

Make the sound mixer column volume slider work like an actual physical mixer by adjusting the sound volume relative to the original sound volume setting.

@AeternumGames
Copy link

That would be really great!
I just want to confirm again what iampremo said: This would be a logical way to go, because that's how physical mixers work. Basically, the sounds should have their own volume settings, as it is now. (Which essentially means that each sound has its own channel) These are then "routed" into an audio group "bus channel" which sums all these sounds and then sets the volume for the whole group, without changing the settings of the individual sounds.

@toby-yoyo toby-yoyo self-assigned this Nov 19, 2024
@toby-yoyo toby-yoyo moved this to In Progress in Team Workload Nov 19, 2024
@toby-yoyo toby-yoyo added this to the 2025.1 milestone Nov 19, 2024
@toby-yoyo
Copy link

  • The column volume slider will now scale the volume of the assets in the column.
  • Sound mixer volume sliders should now audibly update as they are moved.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 20, 2024
@YYBartT YYBartT added the documentation Improvements or additions to documentation are required by this issue label Nov 20, 2024
@YYBartT YYBartT self-assigned this Nov 25, 2024
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Nov 25, 2024
…expected

YoYoGames/GameMaker-Bugs#1481

* Added that the column volume slider sets overall column volume
* Added a sentence on volume sliders updating in real time
* Updated screenshot, replacing "Audio Resources" -> "Audio Assets"
@YYBartT
Copy link

YYBartT commented Nov 25, 2024

Documented the changes as listed above on the Sound Mixer manual page.

@Emc1923
Copy link

Emc1923 commented Jan 9, 2025

Verified in IDE v2024.1300.0.715 Runtime v2024.1300.0.728.

@Emc1923 Emc1923 moved this from Ready for QA to Verified in Team Workload Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation are required by this issue ide-bug Bugs with the GameMaker IDE import An issue imported from the old database
Projects
Status: Verified
Development

No branches or pull requests

5 participants