Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera_set/get_view_*() Functions Related to Following a Target Are Unclear #4529

Closed
ParodyKnaveBob opened this issue Jan 27, 2024 · 0 comments
Assignees
Labels
docs-bug GameMaker Manual Bugs

Comments

@ParodyKnaveBob
Copy link

Description

Monthly IDE (and thus Manual) v2023.11.1.129

I did a lot of digging (and testing) before coming here, and I either failed as a researcher, or the manual lacks information. This relates to #2534 but goes much further, and yet it almost entirely boils down to one question: Does the camera care about its target instance's x and y or its mask_index? (Answer: x and y. I'll file a separate Feature Request re: I expected and would prefer mask_index.)

  • Cameras and Viewports
    No mention of camera targeting, which is probably fine. I just figured I'd mention it explicitly.
  • camera_set_view_speed
    • The opening paragraph (the only paragraph) would improve if it mentioned the target instance in its first sentence.
    • The xspeed and yspeed arguments would improve if they mentioned the target instance at all.
    • The GML example would improve if it were anything more than function(arbitrary_arguments); explained via, The above code will function on the arbitrary arguments.
    • This whole page has zero real explanation what it actually does in relation to an instance moving around in a room.
    • Ontop that, the word target never appears in the page, obfuscating it from relevance and potentially denying it in searches.
    • Ontop that, the page says, camera_id, xspeed, yspeed, and the IDE says, camera, x_speed, y_speed; consistency would be nice, but I understand if this subpoint is low priority.
  • camera_set_view_border
    This page would improve by mentioning that the border relates to the target instance's x and y values (and not its mask_index). It would further improve by advising that if you want the mask_index to act like it has any bearing, you either need to center your sprite origin or math out the border/position manually, depending which direction the target instance moves within the room.
  • camera_set_view_target
    • The syntax definition -- camera_set_view_target(camera_id, instance_id/object_id) -- would improve if that confusing / were removed. See how the instance_destroy Syntax and Arguments sections handle this.
    • This page would improve by noting that the target is only followed via x and y, that if you want the mask_index to act like it has any bearing, you either need to center your sprite origin or math out the border/position manually, depending which direction the target instance moves within the room.
  • camera_get_view_speed_x camera_get_view_speed_y
    • These pages would improve if the speeds being gotten were clarified as being the set speeds vs. the actual current speeds, which then opens the door to noting a targeted instance.
    • The word target never appears on these pages, obfuscating them from relevance and potentially denying them in searches.
  • camera_get_view_border_x camera_get_view_border_y
    • These first sentences would improve if rewritten; just off the top of my head (for x and horizontal): "This function can be used to retrieve the border value of the given camera along the x axis (horizontal border) regarding the camera's target instance to follow."
    • It probably wouldn't hurt their one paragraph to mention the border is the distance from the x or y and not the mask_index.
    • They might improve if their example explanations didn't use xborder and yborder as one-word terms; at the very least, they might use x_border and y_border to match the arguments described on the camera_set_view_border() page.
    • The word target never appears on these pages, obfuscating them from relevance and potentially denying them in searches.
  • camera_get_view_target
    This page might improve if it, too, noted that the target is only followed via x and y and that if you want the mask_index to act like it has any bearing, you either need to center your sprite origin or math out the border/position manually, depending which direction the target instance moves within the room.

It's possible the related IDE tooltips might be improved in conjunction with all this, but them being terse is expected and fine imo. The manual is the real meal to the tooltips' appetizers. $;^ ]

Manual Link

No response

@ParodyKnaveBob ParodyKnaveBob added the docs-bug GameMaker Manual Bugs label Jan 27, 2024
gurpreetsinghmatharoo added a commit to YoYoGames/GameMaker-Manual that referenced this issue May 7, 2024
* Add extra links to the manual entry that specifies YUV platforms for videos - YoYoGames/GameMaker-Bugs#4665
* Build Menu page should specify that 'Create Executable and Launch' will not launch executables packaged as installers - YoYoGames/GameMaker-Bugs#4706
* Spine sprites don't update their bone positions for skeleton_bone_state_get until AFTER the sprite is drawn - YoYoGames/GameMaker-Bugs#2364
* Functions Related to Following a Target Are Unclear - YoYoGames/GameMaker-Bugs#4529
@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload May 7, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-bug GameMaker Manual Bugs
Projects
Status: Ready for QA
Development

No branches or pull requests

2 participants