Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong warning for surface_set_target #5647

Closed
Patchy-DaYo opened this issue Apr 25, 2024 · 2 comments
Closed

Wrong warning for surface_set_target #5647

Patchy-DaYo opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
docs-bug GameMaker Manual Bugs

Comments

@Patchy-DaYo
Copy link

Description

This warning displayed for surface_set_target() is misleading. It looks like a copy/paste from surface_reset_target(). I suggest "this function" to be replaced by "surface_reset_target()" in that specific page to avoid confusing people learning about surfaces.

"If you have not previously set a render target with the function [surface_set_target], using this function will silently (i.e. without any error messages) end all further code execution for the event."

Manual Link

https://manual.gamemaker.io/monthly/en/index.htm#t=GameMaker_Language%2FGML_Reference%2FDrawing%2FSurfaces%2Fsurface_reset_target.htm%23h

@Patchy-DaYo Patchy-DaYo added the docs-bug GameMaker Manual Bugs label Apr 25, 2024
@thennothinghappened
Copy link

I'm a little confused actually here because to me the surface_reset_target() warning is actually completely wrong. Attempting to reset the target without one set actually throws an error ("Unbalanced surface stack"), and does not silently end the event like it claims.

@Patchy-DaYo
Copy link
Author

I agree. It either has to be removed or the wording changed to refer to the example just above it.

@stuckie stuckie moved this from Triage to Backlog in Team Workload Apr 26, 2024
gurpreetsinghmatharoo added a commit to YoYoGames/GameMaker-Manual that referenced this issue May 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload May 7, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-bug GameMaker Manual Bugs
Projects
Status: Ready for QA
Development

No branches or pull requests

4 participants