Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite Editor: GM unstable when moving multiple frames at once in the preview bar #7041

Closed
KormexGit opened this issue Aug 1, 2024 — with GM Bug Reporter · 3 comments
Assignees
Labels
ide-bug Bugs with the GameMaker IDE ltsr3 project This issue has a sample project attached
Milestone

Comments

@KormexGit
Copy link

KormexGit commented Aug 1, 2024

Description

Selecting and moving multiple frames in a sprite at once causes a "GameMaker has become unstable" popup, and also creates weird non-existent frames in the middle of the sprite.

[16:41:35:129(fb79)] Fatal Error! 'UndoManager::DoUndoableAction - Object reference not set to an instance of an object.'
[16:41:35:131(fb79)]    at YoYoStudio.Plugins.SpriteEditor.SpriteEditorModule.<>c__DisplayClass88_0.<DopeSheet_KeyMoved>b__0()
   at YoYoStudio.Core.Utils.UndoManager.DoUndoableAction(String _description, Object _objectsToTrack, Action _actionDelegate, Object _contextOverride)
GameMaker-Beta_oQbe80wgNI.mp4

Steps To Reproduce

  1. Start GM and create a blank new project
  2. Create a new sprite
  3. In the Sprite Editor, right-click in the dopesheet to add more frames/use the hotkey for this until you have 10 frames in the sprite (you can perform this step in the Image Editor also, if you wish)
  4. Click frame 1, press-and-hold shift, then click frame 4 in order to multi-select all 4 frames
  5. Drag them past frame 10 of the animation and observe the frame count keeps going up, but that it's non-existent frames that are being added
  6. Release the mouse button when your selected frames are at the end of the sprite and you have created some of these duff frames mentioned in step 5
  7. Observe the unstable dialog appears

Which version of GameMaker are you reporting this issue for?

IDE v2024.800.0.597 Runtime v2024.800.0.620

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

fc0f5c3c-d48c-4c93-b076-5f1fc913779f

@gm-bug-reporter gm-bug-reporter bot added ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached labels Aug 1, 2024
@stuckie stuckie self-assigned this Aug 1, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Aug 1, 2024
@stuckie stuckie added this to the 2024.8 milestone Aug 1, 2024
@YYDan YYDan changed the title Sprite editor: Moving multiple frames at once causes GameMaker to become unstable Sprite Editor: GM unstable when moving multiple frames at once in the preview bar Aug 6, 2024
@stuckie stuckie moved this from Todo to In Progress in Team Workload Aug 9, 2024
@stuckie stuckie moved this from In Progress to Todo in Team Workload Aug 9, 2024
@stuckie stuckie assigned yyalansavage and unassigned stuckie Aug 9, 2024
@YYDan YYDan added the ltsr3 label Aug 12, 2024
@yyalansavage
Copy link

fix applied in August and LTS branches

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Aug 13, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Aug 16, 2024
@YYDan
Copy link
Collaborator

YYDan commented Aug 19, 2024

Works fine in IDE v2024.800.0.611 Runtime v2024.800.0.635 now - you're no longer able to drag the frames out to create the extra gaps (and also the selection boxes are much more reliable now, as in that earlier version it looked like your selection was changed as you dragged). I have not been able to recreate the instability either.

@YYDan YYDan moved this from Ready for QA to Verified in Team Workload Aug 19, 2024
@alicemoretti
Copy link
Contributor

Verified picked to LTS on both Windows and mac on IDE v2022.0.3.74 Runtime v2022.0.3.85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE ltsr3 project This issue has a sample project attached
Projects
Status: Verified
Development

No branches or pull requests

5 participants