Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Content: surface_reset_target() page wording could be made more accurate #8573

Closed
Bearman18 opened this issue Dec 1, 2024 · 2 comments
Closed

Manual Content: surface_reset_target() page wording could be made more accurate #8573

Bearman18 opened this issue Dec 1, 2024 · 2 comments
Assignees
@YYBartT
Labels
docs-bug GameMaker Manual Bugs
Milestone
2024.13

Comments

@Bearman18
Copy link

Description

The entry states that "This function resets all further drawing from the target surface back to the screen."
More accurately, surface_reset_target resets the target surface to either the last target set with surface_set_target, or to the application surface.
The surface_set_target entry defines this behavior correctly.

Manual Link

https://manual.gamemaker.io/lts/en/GameMaker_Language/GML_Reference/Drawing/Surfaces/surface_reset_target.htm
@Bearman18 Bearman18 added the docs-bug GameMaker Manual Bugs label Dec 1, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Dec 2, 2024
@YYDan YYDan changed the title Inaccuracy in the surface_reset_target entry Manual Content: surface_reset_target() page wording could be made more accurate Dec 2, 2024
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Dec 10, 2024
@YYBartT
docs(general): surface_reset_target() page wording could be made more…
c4d18fa 
… accurate

YoYoGames/GameMaker-Bugs#8573

* Listed all possible drawing targets that surface_reset_target() can reset to
* Changed the "Note" tag on the note to "Warning" (as the function will throw a fatal error in this case)
@YYBartT YYBartT moved this from Backlog to In Progress in Team Workload Dec 12, 2024
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Dec 12, 2024
@YYBartT
docs(general): surface_reset_target() page wording could be made more…
f4c50da 
… accurate

YoYoGames/GameMaker-Bugs/issues/8573

* Moved information on the surface_reset_target() page to the Drawing page
* Added an introduction on the Drawing page, describing when GameMaker draws things
* Also added a section on "Drawing Targets"
* Linked to the "Drawing Targets" section from the surface_reset_target() page
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Dec 13, 2024
@YYBartT
docs(general): surface_reset_target() page wording could be made more…
2fa77a8 
… accurate

YoYoGames/GameMaker-Bugs/issues/8573

Listed the possible draw targets on the surface_reset_target() page
@YYBartT
Copy link

YYBartT commented Dec 13, 2024

Clarified that surface_reset_target() resets to the "previous" draw target and listed the possible options. Also added a new section "Draw Targets" on the Drawing page, listing all possible draw targets in greater detail.

@YYBartT YYBartT closed this as completed Dec 13, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Dec 13, 2024
@YYBartT YYBartT added this to the 2024.13 milestone Dec 16, 2024
@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Dec 16, 2024
@YYBartT YYBartT mentioned this issue Dec 17, 2024
Merged
@mgeddesGM
Copy link

verified

@mgeddesGM mgeddesGM moved this from Ready for QA to Verified in Team Workload Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YYBartT YYBartT

Labels
docs-bug GameMaker Manual Bugs
Projects
Team Workload
Status: Verified
Milestone
2024.13
Development

No branches or pull requests
4 participants
@gurpreetsinghmatharoo @Bearman18 @mgeddesGM @YYBartT