Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Declare the window object as a type with the specific links #1125

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Declare the window object as a type with the specific links #1125

merged 1 commit into from
Mar 30, 2021

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Mar 29, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/schema-blocks] Fixes two eslint warnings about the conversion of window to any

Relevant technical choices:

  • I defined the windows as a type

Test instructions

This PR can be tested by following these steps:

  • It fixes eslint errors. If CR is 👍 and the build is 👍 please merge

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@andizer andizer added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 29, 2021
@increddibelly increddibelly merged commit e91c061 into develop Mar 30, 2021
@increddibelly increddibelly deleted the P2-809-fix-eslint-warnings branch March 30, 2021 06:44
@johannadevos johannadevos added this to the 16.2 milestone Mar 30, 2021
@johannadevos johannadevos added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog changelog: other Needs to be included in the 'Other' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@increddibelly increddibelly increddibelly approved these changes

Assignees
No one assigned
Labels
changelog: other Needs to be included in the 'Other' category in the changelog
Projects
None yet
Milestone
16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@andizer @increddibelly @johannadevos