Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: Remove header background #349

Merged

Conversation

quentinguidee
Copy link
Contributor

  • Improve background contrast with the cards
  • Remove the blocks before titles (they seem to be too much now that the cards are well defined)
  • And remove header background for a more modern look

Since design changes can be controversial I'm very open to 'request changes', and you can close it if you don't like it

Before

image

After

image

@RomainNeup
Copy link

Hello @quentinguidee, could you take the opportunity to change the cog icon on top right with a calendar? A cog suggest a setting or something and it's not.

@quentinguidee
Copy link
Contributor Author

Hello @quentinguidee, could you take the opportunity to change the cog icon on top right with a calendar? A cog suggest a setting or something and it's not.

I'm not sure of the render, because a calendar icon doesn't tell the user that this is a clickable icon

image

@Yooooomi
Copy link
Owner

I like it! Not sure about the calendar icon though haha.

apps/client/src/index.css Outdated Show resolved Hide resolved
Signed-off-by: Quentin Guidée <[email protected]>
@quentinguidee quentinguidee force-pushed the feat/remove-header-background branch from 7479a84 to a679d6b Compare February 28, 2024 20:22
@quentinguidee
Copy link
Contributor Author

Should be fixed

@Yooooomi Yooooomi merged commit e539bb9 into Yooooomi:release/1.8.0 Feb 28, 2024
@Yooooomi
Copy link
Owner

Merged and tested, it's good well done. I merged all the requests for this release so I'm gonna merge to master soon to create release builds. If you have anything blocking the release tell me :)

@quentinguidee
Copy link
Contributor Author

quentinguidee commented Feb 28, 2024

I get migration issue when going to the release branch, should I change something manually in the database?

image

@Yooooomi
Copy link
Owner

This is weird, it feels like the migration file was not compiled / does not exist. I've not gone through this error. I don't know what to tell you actually.

@quentinguidee
Copy link
Contributor Author

Then that's probably an issue caused by my attempt to fix the migration yesterday, that should not impact users.

@Yooooomi
Copy link
Owner

Yeah the file is not named like this haha, it's named 1708973485301-add_metadata_to_infos

@quentinguidee
Copy link
Contributor Author

I edited it manually in mongo and it's fixed yep! Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants