Fix building for MSVC 2019 and static Windows builds #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, we must change C++ flags and add a #define directive in order to get boost python to compile on Windows. Modify the cmake file to add these defines when MSVC is defined. Signed-off-by: Sean Cross <[email protected]>
The CRAM file makes use of `runtime_error`, which is defined in <stdexcept>. Previously, this header file wasn't included. This fixes the build on MSVC 16 (Visual Studio 2019). Signed-off-by: Sean Cross <[email protected]>
Add Windows versions of the seed manipulation functions so that ecpbram compiles properly under MSVC. Signed-off-by: Sean Cross <[email protected]>
|
Many thanks for testing and fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset accomplishes two things: