-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] (auto resolution): add fallback setting #461
Comments
@Mabra51 I will look into implementing a fallback resolution option |
@Mabra51 can you provide more information about how you want this fallback strategy to work. I was thinking about how I can implement this and came to the conclusion it isn't practical. If you select 480p and it isn't available the quality can only be lower. I've never seen a video have a quality level missing if it has higher quality it has the lower levels. |
@Mabra51 How the automatic quality feature functions currently is as follows: |
You mean it's already supposed to do that ? I have it set to 480, but when a video doesn't have it it just goes to 1080, instead of 720 or 360. |
Yes it is. Can you provide a link to a video so I can test this behavior. |
Here's the most recent video i watched that lacks 480p. |
Thank you. I didn't realize videos could lack lower resolutions. I'll test and then look into fixing this. |
@Mabra51 I will start to work on this tomorrow |
I'm going to add a fallback mode that the user can configure the options will be higher and lower. If the desired resolution isn't available one lower or higher resolution will be picked based on the setting |
@Mabra51 how does this look? Do you understand the meaning of the label and title |
Yes, that's what i had in mind. 👍 |
Thanks for replying. I'll commit the code and merge it to dev branch later today. |
@all-contributors please add @Mabra51 for ideas |
I've put up a pull request to add @Mabra51! 🎉 |
# [1.26.0](v1.25.0...v1.26.0) (2024-06-29) ### Bug Fixes * broken features ([742be90](742be90)) * Button placement change causing multi buttons to stop working. ([caed598](caed598)) * color pickers opening when they shouldn't ([b53edd7](b53edd7)) * continue when old and new placement is the same ([dd9b089](dd9b089)) * deep dark author/co author title ([a3503d5](a3503d5)) * features with multi buttons placement issue ([50014cb](50014cb)) * object type not being handled properly ([b34b86e](b34b86e)) * old button placement not being removed ([b995911](b995911)) * playback speed button order issue ([186c4c5](186c4c5)) ### Features * **automatic quality:** Fallback strategy [#461](#461) ([c621580](c621580)) * Disable button's placement select when button isn't enabled [#504](#504) ([916b39c](916b39c)) * forward rewind buttons [#486](#486) ([1a80122](1a80122)) * Hide end screen cards button [#484](#484) ([5e047c5](5e047c5)) * hide paid promotion banner [#519](#519) ([5356f8d](5356f8d)) * Setting search bar ([013ce19](013ce19)) ## Release Artifacts | File Name | SHA-256 Hash | | :--- | :---: | | youtube-enhancer-v1.26.0-Chrome.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 | | youtube-enhancer-v1.26.0-Chromium.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 | | youtube-enhancer-v1.26.0-Edge.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 | | youtube-enhancer-v1.26.0-Firefox.zip | 0eee8b8088e4fdbe87b997d252851e4b6918f20180c83574f3405ce2126955fb |
@Mabra51 this feature has been released in version 1.26.0 |
Is your feature request related to a problem? Please describe.
Just a minor issue, but when using the auto resolution feature on videos that don't support the one you set, it defaults to the highest one available (usually 1080p, which takes ages to buffer).
Describe the solution you'd like
I think having a "fallback resolution" setting with the option of the closest available resolution (higher or lower) would be the best solution.
For example with 480p you would get 720p (closest higher) or 360p (closest lower)
The text was updated successfully, but these errors were encountered: