Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add branch.y (and branch.x = branch) in calculate_branch_mid() for positioning on branches in unrooted layouts #412

Closed
wants to merge 1 commit into from
Closed

Add branch.y (and branch.x = branch) in calculate_branch_mid() for positioning on branches in unrooted layouts #412

wants to merge 1 commit into from

Conversation

alephreish
Copy link

Addresses #402. The commit introduces branch.y as well as branch.x (as an alias for branch for the sake of symmetry).

@GuangchuangYu
Copy link
Member

Thanks.

This is useful, and I believe it should be calculated only for unrooted tree. @xiangpin

@xiangpin xiangpin mentioned this pull request Jun 11, 2021
Merged
@alephreish
Copy link
Author

@xiangpin @GuangchuangYu Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alephreish @GuangchuangYu