Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change_url's ynh_permission_url parameters #300

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Fix change_url's ynh_permission_url parameters #300

merged 3 commits into from
Sep 21, 2022

Conversation

tituspijean
Copy link
Member

Fixes #299

PR Status

  • Code finished.
  • Tested with Package_check
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

@tituspijean
Copy link
Member Author

Shouldn't we enable the change url check in check_process?

@Josue-T
Copy link

Josue-T commented Feb 21, 2022

I'm not sure that it will works. But you can try and we will see if it works.

Josue-T
Josue-T reviewed Feb 21, 2022
View reviewed changes
scripts/change_url Outdated Show resolved Hide resolved
Josue-T
Josue-T requested changes Sep 17, 2022
View reviewed changes
scripts/change_url Outdated Show resolved Hide resolved
@tituspijean
Copy link
Member Author

!testme

@yunohost-bot
Copy link

Meow 🐈
Test Badge

@Josue-T Josue-T merged commit 49adc33 into testing Sep 21, 2022
@Josue-T Josue-T deleted the fix-changeurl branch September 21, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josue-T Josue-T Josue-T requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tituspijean @Josue-T @yunohost-bot