Improving go helper #2023
Open
Improving go helper #2023
+146
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Salamandar
reviewed
Jan 5, 2025
helpers/helpers.v1.d/go
Outdated
| @@ -90,7 +80,7 @@ ynh_use_go() { | |||
| ynh_go_load_path="PATH=$PATH" | |||
|
|
|||
| # Sets the local application-specific Go version | |||
| pushd $install_dir | |||
| pushd ${install_dir:-$install_dir} | |||
There was a problem hiding this comment.
What's the meaning of this substitution ?
There was a problem hiding this comment.
Bad copy paste from:
yunohost/helpers/helpers.v1.d/ruby
Line 95 in a96cb9b
| ynh_print_info --message="Downloading goenv..." | ||
| git init -q | ||
| git remote add origin https://github.com/syndbg/goenv.git | ||
| goenv="$(command -v goenv $goenv_install_dir/bin/goenv | grep "$goenv_install_dir/bin/goenv" | head -1)" |
There was a problem hiding this comment.
This command will fail if goenv is not present. You should something like that instead:
if command -v …
There was a problem hiding this comment.
In that case
yunohost/helpers/helpers.v1.d/ruby
Line 135 in a96cb9b
and
yunohost/helpers/helpers.v2.1.d/ruby
Line 77 in a96cb9b
should not be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
There was some issues and missing parts in the go helper
Solution
Use the Ruby helper as starting point to improve the go helper
PR Status
Ready
How to test
Put it in package like lxd and use it / I can do some test PR to show that it works