Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise-based implementation #56

Closed
wants to merge 2 commits into from
Closed

Add Promise-based implementation #56

wants to merge 2 commits into from

Conversation

RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Aug 15, 2016

This pull request adds a Promise-based implementation of setImmediate. It builds upon #55, which was not merged yet, so only fb5129c counts.

Benchmark

Chrome 52 (s) Firefox 47 (s) Safari 9.1.1 (s)
#55 26.6 22.3 14.1
this pull request 5.5 10.3 2.1

@domenic
Copy link
Collaborator

domenic commented Aug 15, 2016

This has incorrect semantics (microtask instead of task). See the readme for more information.

@domenic domenic closed this Aug 15, 2016
@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Aug 15, 2016

Fair enough; I'll probably switch to immediate for my purposes.

@domenic domenic mentioned this pull request May 20, 2017
@RubenVerborgh RubenVerborgh deleted the feature-promise branch May 13, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants