Skip to content

Commit

Permalink
Formatting + remove unused code.
Browse files Browse the repository at this point in the history
Fix up ext generation as well by memsetting the found items.
  • Loading branch information
PhlexPlexico committed Jan 22, 2024
1 parent 0ae153e commit fb87a7a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 18 deletions.
4 changes: 2 additions & 2 deletions code/include/rnd/entrance.h
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#ifndef __RND_ENTRANCE_H
#define __RND_ENTRANCE_H

#include "game/common_data.h"
#include "common/advanced_context.h"
#include "game/common_data.h"
#include "rnd/savefile.h"

void Entrance_EnteredLocation(void);

#endif // __RND_ENTRANCE_H
#endif // __RND_ENTRANCE_H
9 changes: 4 additions & 5 deletions code/source/rnd/entrance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@

namespace rnd {
extern "C" {
void Entrance_EnteredLocation(u16 sceneNum) {
void Entrance_EnteredLocation(u16 sceneNum) {
auto* gctx = rnd::GetContext().gctx;
if (!gctx || gctx->type != game::StateType::Play)
return;



SaveFile_SetSceneDiscovered(sceneNum);
}
}
} // namespace rnd
}
} // namespace rnd
22 changes: 11 additions & 11 deletions code/source/rnd/savefile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,7 @@ namespace rnd {
gExtSaveData.playtimeSeconds = 0;
memset(&gExtSaveData.chestRewarded, 0, sizeof(gExtSaveData.chestRewarded));
memset(&gExtSaveData.scenesDiscovered, 0, sizeof(gExtSaveData.scenesDiscovered));
memset(&gExtSaveData.itemCollected, 0, sizeof(gExtSaveData.itemCollected));
// TODO: Settings options belong in ext.
// memset(&gExtSaveData.scenesDiscovered, 0, sizeof(gExtSaveData.scenesDiscovered));
// memset(&gExtSaveData.entrancesDiscovered, 0, sizeof(gExtSaveData.entrancesDiscovered));
Expand All @@ -787,27 +788,26 @@ namespace rnd {

u8 SaveFile_GetIsSceneDiscovered(u8 sceneNum) {
u32 numBits = sizeof(u32) * 8;
u32 idx = sceneNum / numBits;
u32 idx = sceneNum / numBits;
if (idx < SAVEFILE_SCENES_DISCOVERED_IDX_COUNT) {
u32 bit = 1 << (sceneNum - (idx * numBits));
return (gExtSaveData.scenesDiscovered[idx] & bit) != 0;
u32 bit = 1 << (sceneNum - (idx * numBits));
return (gExtSaveData.scenesDiscovered[idx] & bit) != 0;
}
return 0;
}
}

void SaveFile_SetSceneDiscovered(u16 sceneNum) {
void SaveFile_SetSceneDiscovered(u16 sceneNum) {
if (SaveFile_GetIsSceneDiscovered(sceneNum)) {
return;
return;
}

u16 numBits = sizeof(u32) * 8;
u32 idx = sceneNum / numBits;
u32 idx = sceneNum / numBits;
if (idx < SAVEFILE_SCENES_DISCOVERED_IDX_COUNT) {
u32 sceneBit = 1 << (sceneNum - (idx * numBits));
gExtSaveData.scenesDiscovered[idx] |= sceneBit;
u32 sceneBit = 1 << (sceneNum - (idx * numBits));
gExtSaveData.scenesDiscovered[idx] |= sceneBit;
}
}

}

extern "C" void SaveFile_LoadExtSaveData() {
char path[] = "/0.bin";
Expand Down

0 comments on commit fb87a7a

Please sign in to comment.