-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic 3.13 support, various cleanups and version bumps #37
Conversation
… but parso does not support 3.13
Or I suppose maybe @aneeshusa and/or @thejcannon would be up for a first pass review as well. I'm not 100% sure why |
LGTM
Where are you seeing that exactly? |
although I can't see it in https://github.com/Zac-HD/hypothesmith/pull/37/checks so it's probably just github being weird? |
@Zac-HD can confirm but I suspect that's because the branch protection rules likely still reference that job name? |
Yep, but also 3.8 EOL isn't until October, and I'd prefer not to drop it before then. |
Otherwise looks good - thanks @jakkdl! |
oops, brain going a bit too fast. Will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakkdl!
drops support for 3.8base_python
in thedeps
environment. The files were previously generated with 3.10, so left it at that, although it probably makes more sense to make that3.9
.deps/check.txt
anddeps/test.txt
(feels like there should be atox -e deps
call in CI to check they're up-to-date?)setup.py
, but looking up parso now I guess hyposmith viability does not strictly depend on it having 3.13 support.