WIP - Test cases for base64 module #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
May 17, 2020
There was a problem hiding this comment.
Nice work @akash-suresh, this is a great start 😁
I think you've got the fundamentals down pat, so the comments below are about how we can take it to the next level.
|
Thanks @Zac-HD 😄. I shall look at the comments and make changes accordingly. |
- Added arguments casefold, map01 to b32decode - Added arguments casefold to b16encode & b16decode - Updated wrapcol argument strategy of a85encode to take 0 more often. - Added argument pad to a85encode & a85decode - Added argument pad to b85encode & b85decode - Fixed usage of pad argument in a85decode & b85decode, by manually adding padding when len(payload)!=4
akash-suresh
commented
May 17, 2020
Zac-HD
reviewed
May 18, 2020
|
Thanks @akash-suresh! If you're still interested in writing |
|
Thanks for merging @Zac-HD . This is my first open source contribution 👻 . I have already started on writing tests for |
|
Congratulations! |
|
Cross-reference: HypothesisWorks/hypothesis#2430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Zac-HD I have made an attempt to add a few test cases for the
base64module.I had a doubt - This particular test case
test_b85_encode_with_padding_decode_round_trip, is failing forpayload = b'\x00'. I setpad = Truewhileb85encode. The expectation is thatb85decode, will implicitly remove the padding, but it fails to decode. Let me know your thoughts.