Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nuxt plugin #96

Merged
merged 1 commit into from
Sep 9, 2020
Merged

add nuxt plugin #96

merged 1 commit into from
Sep 9, 2020

Conversation

BuckyMaler
Copy link
Collaborator

@BuckyMaler BuckyMaler commented Aug 30, 2020

The plan was to wait for Vue 3, but I didn't. This plugin has the following features:

  • App schematic for generating a Nuxt app
  • Linter builder for linting with ESLint
  • Test builder for running unit tests with Jest
  • E2E builder for running e2e tests with Cypress
  • Dev server builder for development
  • Browser builder for generating a production build
  • Prod server builder for serving the output of nx build <app>

Todo:

  • Add tests
  • Add documentation
  • Add package metadata

@BuckyMaler BuckyMaler marked this pull request as ready for review September 3, 2020 04:46
@BuckyMaler BuckyMaler requested a review from ZachJW34 September 3, 2020 04:46
@jpsc
Copy link

jpsc commented Sep 3, 2020

🥳 Great work. Thanks.
Question: Wouldn't be possible to leverage the power of https://github.com/nuxt/create-nuxt-app to generate a new app?

@BuckyMaler
Copy link
Collaborator Author

Thanks, @jpsc. The app schematic is inspired by Create Nuxt App and generates very similar output. We may be able to leverage it, but it wouldn't work as-is. We'd need to make changes to its generated output. Plus, we support generating an e2e app with Cypress configured, which Create Nuxt App doesn't support yet. That being said, Create Nuxt App supports options that we don't yet support, so we'll give this some thought.

@ZachJW34
Copy link
Owner

ZachJW34 commented Sep 8, 2020

What do you think of changing the Logo.spec.js to Logo.spec.ts (requires adding the shims-vue.d.ts)? There is a related issue for create-nuxt-app.

@BuckyMaler
Copy link
Collaborator Author

I'm aware of the issue. I think a few small changes may be inspired by it, but I don't think those changes are required for this initial work.

ZachJW34
ZachJW34 previously approved these changes Sep 9, 2020
@ZachJW34
Copy link
Owner

ZachJW34 commented Sep 9, 2020

Rebase and LGTM!

@ZachJW34 ZachJW34 merged commit 4db5eda into ZachJW34:master Sep 9, 2020
@BuckyMaler BuckyMaler deleted the add-nuxt-plugin branch January 5, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants