Skip to content

Commit

Permalink
Merge pull request #640 from Zagrios/chore/remove-broken-models-notif…
Browse files Browse the repository at this point in the history
…ication

[chore] remove the "Broken models" notification
  • Loading branch information
Zagrios authored Nov 4, 2024
2 parents 83f23c5 + ec09ee2 commit 8181cb3
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 47 deletions.
4 changes: 0 additions & 4 deletions assets/jsons/translations/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@
"go-to-mods": "Zu den Mods",
"not-remind": "Nicht mehr erinnern"
},
"prevent-for-models-breaks": {
"title": "Gebrochene Modelle",
"desc": "Seit dem Update der Beat Saber Engine sind alle benutzerdefinierten Modellmods defekt und müssen aktualisiert werden. Sie wurden noch nicht aktualisiert."
},
"export-success": {
"title": "Export abgeschlossen 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -1071,10 +1071,6 @@
"go-to-mods": "Go to mods",
"not-remind": "Don't remind me"
},
"prevent-for-models-breaks": {
"title": "Broken models",
"desc": "Since the Beat Saber engine update, all custom model mods have broken and need to be updated. They have not been updated yet."
},
"export-success": {
"title": "Export completed 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@
"go-to-mods": "Ir a mods",
"not-remind": "No volver a recordarme"
},
"prevent-for-models-breaks": {
"title": "Modelos rotos",
"desc": "Desde la actualización del motor de Beat Saber, todos los mods de modelos personalizados se han roto y necesitan ser actualizados. Todavía no han sido actualizados."
},
"export-success": {
"title": "Exportación completada 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -1065,10 +1065,6 @@
"go-to-mods": "Aller aux mods",
"not-remind": "Ne plus me rappeler"
},
"prevent-for-models-breaks": {
"title": "Modèles cassés",
"desc": "Depuis la mise à jour du moteur Beat Saber, tous les mods de modèles personnalisés ne sont plus fonctionnels et doivent être mis à jour. Ils n'ont pas encore été mis à jour."
},
"export-success": {
"title": "Export terminé 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@
"go-to-mods": "Modインストーラーに移動",
"not-remind": "二度と表示しないで"
},
"prevent-for-models-breaks": {
"title": "モデルが壊れています!",
"desc": "Beat Saberのエンジンアップデート以来、すべてのカスタムモデルのMODが壊れており、更新が必要です。まだ更新されていません。"
},
"export-success": {
"title": "エクスポート完了🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -1063,10 +1063,6 @@
"go-to-mods": "Перейти к модам",
"not-remind": "Больше не напоминать"
},
"prevent-for-models-breaks": {
"title": "Сломанные модели",
"desc": "С момента обновления движка Beat Saber, все пользовательские модификации моделей сломались и требуют обновления. Они еще не были обновлены."
},
"export-success": {
"title": "Экспорт завершен 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/zh-tw.json
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@
"go-to-mods": "前往 Mod 頁",
"not-remind": "不再提醒我"
},
"prevent-for-models-breaks": {
"title": "已損壞的模型",
"desc": "自從Beat Saber引擎更新以來,所有自定義模型的MOD都已損壞,需要更新。它們還沒有被更新。"
},
"export-success": {
"title": "導出成功 🎉"
}
Expand Down
4 changes: 0 additions & 4 deletions assets/jsons/translations/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@
"go-to-mods": "前往 Mod 页",
"not-remind": "不再提醒我"
},
"prevent-for-models-breaks": {
"title": "已损坏的模型",
"desc": "自从Beat Saber引擎更新以来,所有自定义模型的MOD都已损坏,需要更新。它们还没有被更新。"
},
"export-success": {
"title": "导出成功 🎉"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { useOnUpdate } from "renderer/hooks/use-on-update.hook";
import { NotificationService } from "renderer/services/notification.service";
import { ConfigurationService } from "renderer/services/configuration.service";
import { useTranslation } from "renderer/hooks/use-translation.hook";
import { lt } from "semver";
import { lastValueFrom, of, take } from "rxjs";
import { FolderLinkState } from "renderer/services/version-folder-linker.service";
import { BsContentTabItemProps } from "../shared/bs-content-tab-panel/bs-content-tab-item.component";
Expand Down Expand Up @@ -74,20 +73,6 @@ export function ModelsPanel({ version, isActive, goToMods }: { version?: BSVersi
});
}, [isActive]);

useOnUpdate(() => {
if (!isActive || !version || lt(version.BSVersion, "1.29.4")) {
return;
}
if (config.get("not-remind-models-breaks")) {
return;
}
notification.notifyInfo({ title: "models.notifications.prevent-for-models-breaks.title", desc: "models.notifications.prevent-for-models-breaks.desc", actions: [{ id: "0", title: "models.notifications.prevent-for-mods.not-remind", cancel: true }], duration: 12_000 }).then(res => {
if (res === "0") {
config.set("not-remind-models-breaks", true);
}
});
}, [isActive, version]);

const exportModels = () => {
const selectedModels = modelsGridRefs.map(ref => ref.current?.getSelectedModels() as BsmLocalModel[]).flat();
modelsManager.exportModels(selectedModels, version);
Expand Down

0 comments on commit 8181cb3

Please sign in to comment.