Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat-76] support drag and drop of mod files (zip/dll files only) #569

Merged
merged 5 commits into from
Dec 8, 2024

Conversation

silentrald
Copy link
Contributor

@silentrald silentrald commented Aug 25, 2024

Closes #76
Discord QOL

Notes

Screenshots

image

Future features

  • External mods tracker - so that users can view what external mods they have.
    • Warning prompt to ask the user if they want to overwrite an existing mod file/s
  • Disable mods support - BSIPA support mod disabling, looked into UserData/Disabled Mods.json

@silentrald silentrald force-pushed the feat/76 branch 4 times, most recently from 04a3d51 to dad89a4 Compare August 31, 2024 12:54
@silentrald silentrald changed the title WIP: [feat-76] support drag and drop of mod files (zip/dll files only) [feat-76] support drag and drop of mod files (zip/dll files only) Aug 31, 2024
@silentrald
Copy link
Contributor Author

Hi @Zagrios, should be done with the PR. Only missing some art assets and resource text but most of the logic should be done. Can you check if I missed any handlings?

Also for the SonarCloud code analysis, can you also check if I need to resolve those or the code should be safe? Can't really check in my local development if I've resolve them quite right.

@Zagrios
Copy link
Owner

Zagrios commented Sep 11, 2024

Hi I will try to review your PR this week 👌 hopefully tomorrow

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarCloud

@silentrald silentrald marked this pull request as draft October 22, 2024 12:50
@silentrald silentrald force-pushed the feat/76 branch 2 times, most recently from 8c26e5e to b533100 Compare November 16, 2024 10:18
@silentrald silentrald marked this pull request as ready for review November 16, 2024 10:20
@Zagrios
Copy link
Owner

Zagrios commented Dec 8, 2024

@silentrald can you resolve conflicts ?

@silentrald
Copy link
Contributor Author

@Zagrios rebased 👌

Although can we leave #76 since maybe External mods tracker is kinda crucial for that issue. Will do that in a separate PR once this gets merged, so that the changes are incremental and not in one go, like my previous change 😅

Copy link

sonarqubecloud bot commented Dec 8, 2024

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Dec 8, 2024

Thanks @silentrald ❤️
Merging 🚀

@Zagrios Zagrios merged commit cfae1d9 into Zagrios:master Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT.] : Drag drop mod to install it
2 participants