[feat/663] Option to launch BS without SteamVR #664
Conversation
| @@ -77,8 +77,11 @@ export class SteamLauncherService extends AbstractLauncherService implements Sto | |||
| throw CustomError.fromError(new Error(`Path not exist : ${exePath}`), BSLaunchError.BS_NOT_FOUND); | |||
| } | |||
|
|
|||
| const staticConfigService = StaticConfigurationService.getInstance(); | |||
| const launchVREnabled = await staticConfigService.get("disable-launch-vr"); | |||
There was a problem hiding this comment.
From a readability standpoint, this is very confusing. If "disable-launch-vr" is true then this will check if steam is running. Might want to use "enable-launch-vr" instead, or "enable-steamvr-launch" that other dev may get context that this is tied to SteamVR and Steam.
There was a problem hiding this comment.
I did that originally but changed it to match the formatting of hardware acceleration 💀
Alright that's easy enough to redo
| const staticConfigService = StaticConfigurationService.getInstance(); | ||
| const launchVREnabled = await staticConfigService.get("disable-launch-vr"); |
There was a problem hiding this comment.
Remove the staticConfigService variable and use the this.staticConfig member variable instead.
|
@LiamillionSS How about putting that in the advanced launch panel instead? 🤔 |
LiamillionSS
force-pushed
the
feat/663
branch
from
fcee85f to
a154aa3
Compare
LiamillionSS
force-pushed
the
feat/663
branch
from
a38aa9d to
ef72ba6
Compare
|
@LiamillionSS Can you replace "Skip SteamVR" with "Skip Steam"? 🤔 |
| @@ -37,6 +37,9 @@ export abstract class AbstractLauncherService { | |||
| if (launchOptions.additionalArgs) { | |||
| launchArgs.push(...launchOptions.additionalArgs); | |||
| } | |||
| if (launchOptions.launchVR) { | |||
| launchArgs.push(...launchOptions.launchVR); | |||
There was a problem hiding this comment.
@LiamillionSS is this still relevant 🤔 ?
There was a problem hiding this comment.
Remind me to never rebase again
|
|
Thanks @LiamillionSS ❤️ |
Closes #663, which is to add a button to the Advanced Settings that enables and disables the "openSteam" part of the launch functionality when toggled (+ minor typo)
Set to enable launching as default to match original configuration
Once wording is finalised I will add the rest of the translations