Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Add Italian translation #721

Merged
merged 32 commits into from
Jan 3, 2025
Merged

Conversation

Davitekk
Copy link
Contributor

Everything works but i have the same problem with making a rounded flag.
I took as reference the changes that izuna_1 did to the code -> Pull Request For Reference

The Flag Problem

Other Screenshots of how it turned out:

Screenshot 1
Screenshot 2

@Zagrios
Copy link
Owner

Zagrios commented Jan 2, 2025

@Davitekk you can use this for the flag :

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 71 48" ref={ref} {...props} width="71" height="48">
            <g fill="none">
                <path d="M6.65.53A6.36 6.36 0 0 0 .29 6.89v34.27a6.36 6.36 0 0 0 6.36 6.36h17v-47z" fill="#57A863"/>
                <path d="M23.63.53v47H47v-47z" fill="#FFF"/>
                <path d="M63.92.53H47v47h16.92a6.36 6.36 0 0 0 6.36-6.36V6.89A6.36 6.36 0 0 0 63.92.53" fill="#ED5565"/>
            </g>
</svg>

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some translations are missing @Davitekk

assets/jsons/translations/it.json Show resolved Hide resolved
assets/jsons/translations/it.json Show resolved Hide resolved
assets/jsons/translations/it.json Outdated Show resolved Hide resolved
@Davitekk
Copy link
Contributor Author

Davitekk commented Jan 2, 2025

Everything should be resolved.

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some translations are missing

assets/jsons/translations/it.json Show resolved Hide resolved
assets/jsons/translations/it.json Outdated Show resolved Hide resolved
@Davitekk
Copy link
Contributor Author

Davitekk commented Jan 2, 2025

Resolved.

Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Jan 3, 2025

Thanks a lot @Davitekk ! ❤️
Merging 🚀

@Zagrios Zagrios merged commit bf4e5ae into Zagrios:master Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants