Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] handle version view page if state/version becomes null #722

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

silentrald
Copy link
Contributor

Issue replication in discord

How to test

  • Try to replicate with the discord, where they tried to verify their files but incorrectly passed a password.
  • Try to invoke navigate("/bs-version/<some version number>"); where you don't pass { state: version } as the 2nd parameter.

@silentrald silentrald force-pushed the bugfix/null-version-unhandled branch from 8e925f2 to a487871 Compare January 1, 2025 02:58
Copy link

sonarqubecloud bot commented Jan 1, 2025

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Jan 1, 2025

Thanks @silentrald ❤️
Merging 🚀

@Zagrios Zagrios merged commit d6b07cc into Zagrios:master Jan 1, 2025
5 checks passed
@silentrald silentrald deleted the bugfix/null-version-unhandled branch January 2, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants