Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatpak dependencies to non-EOL versions #724

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

eaglesemanation
Copy link
Contributor

Scope

electron-builder defaults to 20.08 version of flatpak runtime and base packages. Those packages are EOL, here is example message from flatpak cli:

Info: runtime org.freedesktop.Platform branch 20.08 is end-of-life, with reason:
   org.freedesktop.Platform 20.08 is no longer receiving fixes and security updates. Please update to a supported runtime version.

I couldn't really find a source of truth for those messages, I suspect it just part of flatpak repository that can report if package is EOL

Implementation

Manually specify versions for both runtime and base package. This will require to manually bump them later on, but it's just 2 lines of code change approximately every 2 years, so I hope that's not an issue =)

Screenshots

before after

How to Test

Try building flatpak package on a linux distro with npm run publish:flatpak

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

Copy link

sonarqubecloud bot commented Jan 1, 2025

@silentrald
Copy link
Contributor

silentrald commented Jan 2, 2025

@eaglesemanation Seems to be good, could build and run the flatpak on my system.

@Zagrios could merge this PR. No workflow changes as well.

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Jan 2, 2025

Thanks a lot @eaglesemanation ! ❤️
Thanks @silentrald for the review 🙌
Merging 🚀

@Zagrios Zagrios merged commit 93ea2e1 into Zagrios:master Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants