Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix-733] manually set WINEPREFIX when executing IPA.exe #734

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

silentrald
Copy link
Contributor

@silentrald silentrald commented Jan 9, 2025

Closes #733

Should set WINEPREFIX=$STEAM_DIR/steamapps/compatdata/620980/pfx when executing the IPA.exe. Should also handle the edge case where the compat folder 620980 is not yet created. This should also work in flatpak.

Also added a way to separately log information for bsmSpawn/bsmExec like for command or environment variables.

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Jan 11, 2025

Thanks @silentrald ! ❤️
Merging! 🚀

@Zagrios Zagrios merged commit 467ca6e into Zagrios:master Jan 11, 2025
5 checks passed
@silentrald silentrald deleted the bugfix/733 branch January 11, 2025 13:39
@silentrald
Copy link
Contributor Author

@Zagrios there is still bug that exists here where the WINEPREFIX folder does not exist. We can't run the wine64 command before proton or else Beat Saber doesn't launch. Might create another PR to address that specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] : BSIPA install failed on Linux
2 participants