This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat(concave): Add Concave LSDCNV Integration #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,28 @@ | |||
| import axios from 'axios'; | |||
| export const getuserPositions = async () => { | |||
| const gqlUrl = 'https://concave.hasura.app/v1/graphql'; | |||
There was a problem hiding this comment.
Hey @ibeandyy, most of your PR looks good but I'm a little nervous about this part here since I don't think the GQL server will stand up to our traffic. I know what you're trying to do though, and I think we can get the Lock events directly from our Ethers instance. I'll merge your PR and try to make that change (its not documented, so I don't want you to have to struggle with figuring out on your own 🙏 )
immasandwich
approved these changes
Sep 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for Concave staking contract
Checklist
How to test?
/apps/concave/balances?addresses[]=0x3c1c5DD60D1C28Ca1adf907b08737EDedF6D29fB&network=ethereum
/apps/concave/positions?groupIds[]=lsdcnv&network=ethereum