Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(templates): Support proxy protocols and add data prop defaults for app token fetchers #1741

Merged
merged 5 commits into from
Nov 17, 2022
Merged

feat(templates): Support proxy protocols and add data prop defaults for app token fetchers #1741

merged 5 commits into from
Nov 17, 2022

Conversation

immasandwich
Copy link
Contributor

Description

  • DeFiSaver doesn't actually have positions of its own
  • We resolve positions from other protocols and their balances
  • Abstract resolving positions and the account address to enable this kind of protocol
  • Also, add smart defaults for data props instead of having to repeat impls for getReserves, getLiquidity, and getApy

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@immasandwich immasandwich merged commit 559f33a into main Nov 17, 2022
@immasandwich immasandwich deleted the support-proxy-protocols branch November 17, 2022 16:06
@zapper-bot zapper-bot mentioned this pull request Nov 17, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@immasandwich