This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat: add pirex gmx tracking #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpoulin
reviewed
Feb 4, 2023
There was a problem hiding this comment.
This is a suggestion which is optional, but because ArbitrumPirexApxgmxTokenFetcher and ArbitrumPirexApxglpTokenFetcher share the same logic, you could either extract the shared logic or have both in the same app token using definitions.
I'll approve it as soon as you've defined groupLabels for both app tokens
wpoulin
approved these changes
Feb 9, 2023
0xdapper
pushed a commit
to 0xdapper/studio
that referenced
this pull request
Feb 28, 2023
* feat: add pirex gmx tracking * fix: add group labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tracking for new px wrapper tokens and vault autocompounders with the new pirex gmx update. Tokens added are pxGMX, pxGLP, apxGMX, and apxGLP.
Checklist
How to test?
pxGMX: 0x9a592b4539e22eeb8b2a3df679d572c7712ef999
pxGLP: 0x0eac365e4d7de0e293078bd771ba7d0ba9a4c892
apxGMX: 0x61dbc0d6d7a6bde37f93d2014044a7c6b6de34d2
apxGLP: 0x6cec1903eae091bdc532cfde68fff0723fd3ee14